Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use the site default language #3550

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Allow to use the site default language #3550

merged 3 commits into from
Jul 25, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR adds a new Default to Site Language option to the language selection in ElasticPress' settings page

Changelog Entry

Added - New Default to Site Language option in the language dropdown in ElasticPress' settings page

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.7.0 milestone Jul 21, 2023
burhandodhy
burhandodhy approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit eb3dfa2 into develop Jul 25, 2023
8 checks passed
@felipeelia felipeelia deleted the feature/lang-site-default branch July 25, 2023 12:19
@felipeelia felipeelia mentioned this pull request Jul 25, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees

@burhandodhy burhandodhy

Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeelia @burhandodhy